primitive-types: update to scale-info 0.9#556
Conversation
scale-info, removes parity-scale-codec direct dependencyscale-info 0.9
|
could you please update the changelogs as well? |
ordian
left a comment
There was a problem hiding this comment.
It's quite unfortunate that a breaking change in scale-info propagates to every single crate.
The problem is largely parity-util-mem though.
Co-authored-by: Andronik Ordian <write@reusable.software>
Indeed it is very annoying. Perhaps we could follow the pattern with |
Gah, even then a version bump would still cascade up the dependency tree. Once we have |
Yes, the problem is largely the design of |
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
|
Hey @ordian, just had an idea: in order to prevent another release like this, what about if we expand the requirements for
This means that when |
Brilliant! If you're confident it won't change in 1.0 and the tests won't break, then go ahead! |
|
Great, I'll try it out now and see if works. |
Hm actually those tests were failing because that builder code has changed, looks like the CI doesn't run them with the Actually I don't think those tests provide much value, essentially just checking the generated code from |
The CI is being fixed in #559, looks like we lost travis at some point.
The tests are not a blocker for a breaking change actually (because it won't break compilation upstream), but I think they provide a value in making sure the generated derive is correct, but feel free to remove them. |
Latest
scale-inforelease https://github.com/paritytech/scale-info/releases/tag/v0.9.0.Required for paritytech/substrate#8615.
It removes the
parity-scale-codecdirect dependency, so might help with #552.